Fix dangling reference #10135
Merged
Fix dangling reference #10135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[What]
Refactor the Remove.cpp to use a local variable for
positionalArguments() return.
[Why]
To fix the compilation issue:
error: possibly dangling reference to a temporary
The parser->positionalArguments() function returns a
temporary QList object, and at(1) returns a reference
to an element in that list.
But the temporary QList object is destroyed after this
line of code, leaving entryPath to be a dangling reference.
droidmonkey
reviewed
Dec 29, 2023
The previous code assigned entryPath in two steps, first by getting the positional arguments from the parser, and then by selecting the second argument. This was modified to a single-line assignment for better readability and code simplicity.
droidmonkey
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation error: dangling reference #10134
Screenshots
N/A
Testing strategy
The build was tested locally by the commands:
cd build cmake -DWITH_XC_ALL=ON -DCMAKE_BUILD_TYPE=Debug -DWITH_TESTS=ON -DWITH_GUI_TESTS=ON .. make -j8Type of change