Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression hint #464

Merged
merged 6 commits into from
Jan 20, 2025
Merged

Compression hint #464

merged 6 commits into from
Jan 20, 2025

Conversation

ftheirs
Copy link
Collaborator

@ftheirs ftheirs commented Jan 16, 2025

Latest feature from OS upgrade to v0.13.3. This PR includes the compression hint that was the missing part to get all the tests from the CI in ✅

Supersedes #463
Issue Number: N/A

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

ftheirs and others added 5 commits January 16, 2025 13:12
* fix: handle kzg compression correctly

* lint: clippy and fmt

* fix: replace unwrap with expect for get_index

* add: docs and tests for the compression module
@ftheirs ftheirs mentioned this pull request Jan 17, 2025
9 tasks
@ftheirs ftheirs marked this pull request as ready for review January 17, 2025 12:28
Copy link
Collaborator

@whichqua whichqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny change!

crates/starknet-os/src/hints/vars.rs Outdated Show resolved Hide resolved
@ftheirs ftheirs requested a review from whichqua January 20, 2025 13:52
Copy link
Collaborator

@whichqua whichqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@HermanObst HermanObst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whichqua whichqua merged commit 51079c6 into os_v0_13_3 Jan 20, 2025
5 checks passed
@whichqua whichqua deleted the compression_hint branch January 20, 2025 14:42
whichqua added a commit that referenced this pull request Jan 23, 2025
* Ft/os upgrade (#453)

* update cairo-lang to v0.13.3

* expect Starknet v0.13.3 version

* set_state_updates_start & set_compressed_start

* update deserialize OS output

* hint implementation: set_n_updates_small

* disable test until we get a reference PIE with the new OS version

* set full_output for integration tests

* deserialize output fix tests

* update sequencer address

* fix CI: bump cairo-lang to v0.13.3

* clippy

* bump cairo-lang

* fix tests

* fix use_kzg_da global variable

* add hint test

* fix is_s_updates_small

* add tests for set_compressed_start and set_state_updates_start

* fix StarknetGeneralConfig

* add test with reference PIEs

* log2 hint (#454)

* feat: add the log2_ceil hint

* simplify log2 function

* clean up unimplemented.rs

---------

Co-authored-by: whichqua <[email protected]>

* Dict hints (#455)

* feat: add dict manager and get offset hints for v0.13.3

* use TOTAL_N_BUCKETS from constants

* handle error

* rename dict to compression

* compression constants

* change unimplemented.rs description

* clippy

---------

Co-authored-by: whichqua <[email protected]>

* Compression hint (#464)

* compression hint

* set_decompressed_dst hint

* use log2 from math.rs

* add test get_n_elms_per_felt

* fix: handle `full_output` compression correctly (#461)

* fix: handle kzg compression correctly

* lint: clippy and fmt

* fix: replace unwrap with expect for get_index

* add: docs and tests for the compression module

* remove unused constant

---------

Co-authored-by: Geoffrey Mureithi <[email protected]>

* feat: decompress the output to state diff (#466)

* feat: decompress the output to state diff

* chore: replace unwraps with expect

* fix: minor replacements of if with match

---------

Co-authored-by: whichqua <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants