feat: Rainbow Quest #135
Merged
feat: Rainbow Quest #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@b-j-roberts hi, here is the Rainbow Quest with 2 tests, one that should be successful and the other one that should fail if the user didn't place pixels of all colors that compose the palette. |
b-j-roberts
requested changes
May 7, 2024
|
After this issue, there is some refactoring I would like to do on the quests, if you would like to work on them.
|
|
Sure ! |
|
@b-j-roberts comments addressed and conflicts resolved ! |
Feel free to start on those things. I'll just copy what I wrote into an issue and we can discuss there if you have questions/concerns. |
mubarak23
pushed a commit
to mubarak23/art-peace
that referenced
this pull request
May 8, 2024
* rainbow quest * add tests * add should panic test * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Rainbow Quest.
It also adds a missing
is_claimedfunction to the Authority Quest (i forgot it in my previous PR) .Closes #129