Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft nft mint quest #121

Merged
merged 12 commits into from
May 7, 2024

Conversation

mubarak23
Copy link
Contributor

@mubarak23 mubarak23 requested a review from b-j-roberts as a code owner May 1, 2024 18:25
@mubarak23
Copy link
Contributor Author

am getting the following error when i ran the test
Got an exception while executing a hint: Hint Error: 0x4661696c656420746f20646573657269616c697a6520706172616d202331 ('Failed to deserialize param #1')
@b-j-roberts what could be the cause of this base on the test i write

@ptisserand
Copy link
Contributor

am getting the following error when i ran the test Got an exception while executing a hint: Hint Error: 0x4661696c656420746f20646573657269616c697a6520706172616d202331 ('Failed to deserialize param #1') @b-j-roberts what could be the cause of this base on the test i write

Hi, you declare the wrong contract here
You have to call declare("NFTMintQuest"); instead of declare("CanvasNFT");

@mubarak23
Copy link
Contributor Author

am getting the following error when i ran the test Got an exception while executing a hint: Hint Error: 0x4661696c656420746f20646573657269616c697a6520706172616d202331 ('Failed to deserialize param #1') @b-j-roberts what could be the cause of this base on the test i write

Hi, you declare the wrong contract here You have to call declare("NFTMintQuest"); instead of declare("CanvasNFT");

you are right here,

after changing it , am getting the following error

Got an exception while executing a hint: Requested contract address ContractAddress(PatriciaKey(StarkFelt("0x000000000000000000000000000000000000000000000043616e7661734e4654"))) is not deployed.

@ptisserand
Copy link
Contributor

Hi, you declare the wrong contract here You have to call declare("NFTMintQuest"); instead of declare("CanvasNFT");

you are right here,

after changing it , am getting the following error

Got an exception while executing a hint: Requested contract address ContractAddress(PatriciaKey(StarkFelt("0x000000000000000000000000000000000000000000000043616e7661734e4654"))) is not deployed.

`utils::NFT_CONTRACT() doesn't deploy a NFT contract, it only returns an hardcoded contract address.

In your is_claimable implementation, you call get_nft_minter.
So you need to declare&deploy a CanvasNFT before deploying your NFTMintQuest contract.

@mubarak23
Copy link
Contributor Author

Hi, you declare the wrong contract here You have to call declare("NFTMintQuest"); instead of declare("CanvasNFT");

you are right here,
after changing it , am getting the following error
Got an exception while executing a hint: Requested contract address ContractAddress(PatriciaKey(StarkFelt("0x000000000000000000000000000000000000000000000043616e7661734e4654"))) is not deployed.

`utils::NFT_CONTRACT() doesn't deploy a NFT contract, it only returns an hardcoded contract address.

In your is_claimable implementation, you call get_nft_minter. So you need to declare&deploy a CanvasNFT before deploying your NFTMintQuest contract.

so after i deploying the NFT_CANVAS contract, am now getting the following

Failure data:
    Got an exception while executing a hint: Hint Error: Error in the called contract (0x0735d0f59362f724897cee0ef1d6ad97ece788dcc126fefb45656ff43d872698):
Error at pc=0:1679:
Got an exception while executing a hint: Requested contract address ContractAddress(PatriciaKey(StarkFelt("0x00000000000000000000000000000000000000004e46544d696e745175657374"))) is not deployed.
Cairo traceback (most recent call last):
Unknown location (pc=0:271)
Unknown location (pc=0:1241)

only art_peace::tests::nft_quest::test_is_claimable fails

onchain/src/quests/nft_quest.cairo Outdated Show resolved Hide resolved
onchain/src/tests/nft_quest.cairo Outdated Show resolved Hide resolved
onchain/src/tests/nft_quest.cairo Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants