Testnet-ready end-to-end test script #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the local BTC node logic and always mine to a predictable address.
Got rid of the direct dependency on Bitcoin RPC node and use Electrum with the offline bcoin wallet instead.
nkuba
reviewed
Aug 4, 2020
| # Get an address. | ||
| address=$(btccli getnewaddress) | ||
| # Use a specific private key. | ||
| privateKey="cTj6Z9fxMr4pzfpUhiN8KssVzZjgQz9zFCfh87UrH8ZLjh3hGZKF" |
There was a problem hiding this comment.
Is it expected that this is the same value as stored in kube's secret e2e-test-secret/bitcoin-depositor-pk?
There was a problem hiding this comment.
This is not necessary but it can be if there is such intention. bitcoin/bitcoind/entrypoint.sh is the local BTC node script and here we use an explicit private key in order to send the coinbase to a predictable address and use it as input for deposit transactions in the e2e test script executed against the local environment.
nkuba
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: keep-network/tbtc#703
Depends on: keep-network/tbtc.js#58Here we modify the
e2e-test.jsscript to enable the interaction with Keep testnet.Summary
local-setupinstances and testnet.sendtoaddress. This opens new customization capabilities for future (e.g. test different types of transactions)local-setupscripts to keep the current functionalityDockerfilewhich allows to build and rune2e-test.jsindependently against an arbitrary environment and avoid the installation of alocal-setupinstancedeployments/e2e-test) to continuously execute the e2e test script against the testnet