This repository has been archived by the owner on May 22, 2023. It is now read-only.
Adding a delay of 1 sec in retry loops #409
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added for signer generation. - Added for signature calculation.
nkuba
reviewed
Apr 17, 2020
|
In the other PR we're adding yet another step with |
|
We should consider adding the delay in every retry loop we do For this PR we could start with a simple 1-second sleeps and TODOs left in the code. Then it could be replaced with the backoff. Issue: #413 |
We added retry delay in case any contrac call within signature publication loop errors.
This change improves redability of the value so at first seight reader is sure the value is <b>1</b> second.
We want to replace sleep on retries with a solution including a backoff described in #413
pdyraga
approved these changes
Apr 18, 2020
nkuba
added a commit
that referenced
this pull request
May 20, 2020
We added retry delay to loops where it's possible to continue the loop execution in case of an error. The solution is similiar to the one we added in #409. If loop execution gets an error for any reason, e.g. problems with connection to the ethereum API the client ended up in a crazy loop logging huge amount of errors. This causes disk space drain by the log file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #395
Adding a short delay interval of 1 sec. upon failure when calculating a signature and signer generation.