Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated telemetry notification #4397

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Remove outdated telemetry notification #4397

merged 2 commits into from
Jan 9, 2025

Conversation

DimedS
Copy link
Member

@DimedS DimedS commented Jan 3, 2025

Description

We have transitioned to an opt-out telemetry model (see documentation), making this notification redundant and no longer necessary.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@DimedS DimedS requested a review from noklam January 8, 2025 16:07
@DimedS DimedS marked this pull request as ready for review January 9, 2025 13:22
@DimedS DimedS merged commit c6bc8d5 into main Jan 9, 2025
10 checks passed
@DimedS DimedS deleted the remove-outdated-telemetry-notification branch January 9, 2025 13:23
astrojuanlu
astrojuanlu reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu left review comments

@noklam noklam noklam approved these changes

@ankatiyar ankatiyar ankatiyar approved these changes

@ravi-kumar-pilla ravi-kumar-pilla Awaiting requested review from ravi-kumar-pilla

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone