-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHG: switch to ruff format instead of black entirely #3435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Yes! Approving this with some nitpicks
7927c9c
to
d0f25f9
Compare
cca7386
to
d9c5514
Compare
#3395 is getting annoying... |
I really like this suggestion, but we should then also update the behaviour of our |
@merelcht Agreed, better to switch to I found some obviated It would be good to create a follow-up story that expands the selection of |
Signed-off-by: Simon Brugman <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for switching everything to ruff format
@sbrugman ⭐ I left some minor comments, but otherwise this looks good to go! 👍
I also agree on creating a follow up to leverage ruff more where we can.
The tests are currently failing because the |
Co-authored-by: Merel Theisen <[email protected]> Signed-off-by: Simon Brugman <[email protected]>
Created a PR for this kedro-org/kedro-starters#207 |
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏Appreciate your help!
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Added a change so that unit tests now use the |
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Description
Recommend
ruff format
instead ofblack
Benefits performance as well as fewer dependencies that can conflict (e.g.
click
)Link to ruff's pre-commit version to avoid having to update the docs every time there is a new release, which are frequent.
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file