-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistently write "PySpark" rather than "Pyspark" #3259
Conversation
92f4fdd
to
7ac990d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
But we probably need to apply this across the board for all Kedro docs and datasets/starters/etc as I imagine it's widespread.
I actually didn't find any other instances in the repo, even though I did just notice during the morning's add-ons presentation. It may be the case in some of the other repos. Edit: There seems to be one instance in Kedro-Plugins. |
Signed-off-by: Deepyaman Datta <[email protected]>
7ac990d
to
b603d25
Compare
Actually, good point; I think kedro-org/kedro-starters#179 is necessary for this to work. I also made a change in datasets, although there's no dependency there. |
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
This can be merged now I think, right @AhdraMeraliQB @deepyaman ? |
Description
Development notes
Interdependent: kedro-org/kedro-starters#179
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file