Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently write "PySpark" rather than "Pyspark" #3259

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Nov 1, 2023

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Development notes

Interdependent: kedro-org/kedro-starters#179

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@deepyaman deepyaman requested a review from merelcht as a code owner November 1, 2023 15:52
@deepyaman deepyaman force-pushed the chore/capitalize-spark branch from 92f4fdd to 7ac990d Compare November 1, 2023 15:52
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

But we probably need to apply this across the board for all Kedro docs and datasets/starters/etc as I imagine it's widespread.

@deepyaman
Copy link
Member Author

deepyaman commented Nov 1, 2023

Yes!

But we probably need to apply this across the board for all Kedro docs and datasets/starters/etc as I imagine it's widespread.

I actually didn't find any other instances in the repo, even though I did just notice during the morning's add-ons presentation. It may be the case in some of the other repos.

Edit: There seems to be one instance in Kedro-Plugins.

@deepyaman deepyaman force-pushed the chore/capitalize-spark branch from 7ac990d to b603d25 Compare November 1, 2023 17:12
@deepyaman
Copy link
Member Author

Yes!

But we probably need to apply this across the board for all Kedro docs and datasets/starters/etc as I imagine it's widespread.

Actually, good point; I think kedro-org/kedro-starters#179 is necessary for this to work. I also made a change in datasets, although there's no dependency there.

@merelcht
Copy link
Member

merelcht commented Nov 2, 2023

I don't know if it makes sense to merge this before #3228. IMO this is kind of part of the design review tracked in #3054

@deepyaman
Copy link
Member Author

I don't know if it makes sense to merge this before #3228. IMO this is kind of part of the design review tracked in #3054

Whatever works; I'm not entwined in this work, and just raised it based on what I noticed yesterday, so feel free to merge whenever it makes sense.

@stichbury
Copy link
Contributor

This can be merged now I think, right @AhdraMeraliQB @deepyaman ?

@merelcht merelcht enabled auto-merge (squash) December 7, 2023 11:13
@merelcht merelcht merged commit 5f24e85 into develop Dec 7, 2023
@merelcht merelcht deleted the chore/capitalize-spark branch December 7, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants