Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kedro viz --lite slowness #2271

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix kedro viz --lite slowness #2271

wants to merge 4 commits into from

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Feb 12, 2025 •
edited
Loading

Description

Resolves #2231

Development notes

  • Added spinner to show users a sign of processing
  • Added logic to ignore hidden files and gitignored files (Reused code of gitignore in autoreload done by @jitu5)
  • Updated log level to Warning as discussed
  • Updated tests

QA notes

  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla
temp change
506437f 
Signed-off-by: ravi_kumar_pilla <[email protected]>
@ravi-kumar-pilla
ignore files which are hidden and in gitignore
d052dd1 
Signed-off-by: ravi_kumar_pilla <[email protected]>
@ravi-kumar-pilla
add tests
ce69481 
Signed-off-by: ravi_kumar_pilla <[email protected]>
@ravi-kumar-pilla
update release note
686a8a0 
Signed-off-by: ravi_kumar_pilla <[email protected]>
@ravi-kumar-pilla ravi-kumar-pilla changed the title Fix viz --lite slowness Fix kedro viz --lite slowness Feb 12, 2025
@ravi-kumar-pilla ravi-kumar-pilla changed the title Fix kedro viz --lite slowness Fix kedro viz --lite slowness Feb 12, 2025
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review February 12, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashidakanchwala rashidakanchwala Awaiting requested review from rashidakanchwala rashidakanchwala is a code owner

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu astrojuanlu is a code owner

@jitu5 jitu5 Awaiting requested review from jitu5

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lite Viz is too slow
1 participant
@ravi-kumar-pilla