Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add official support for python 3.13 #258

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add official support for python 3.13 #258

wants to merge 10 commits into from

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Nov 14, 2024 •
edited
Loading

Motivation and Context

Support for python 3.13
Resolves #259

How has this been tested?

  • All tests should pass

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

@ravi-kumar-pilla ravi-kumar-pilla mentioned this pull request Nov 15, 2024
Closed
9 tasks
This was referenced Nov 21, 2024
Closed
Open
@astrojuanlu
Copy link
Member

What's the status of this @ravi-kumar-pilla ? 😄

@ravi-kumar-pilla
Copy link
Contributor Author

Add official support for Python 3.13 kedro-org/kedro#4267

Was waiting for - https://www.python.org/downloads/release/python-3131/
Thanks for reminding 👍 . This is good to be reviewed now

@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review February 7, 2025 15:13
@ravi-kumar-pilla
address PR comments
1726bde 
Signed-off-by: ravi_kumar_pilla <[email protected]>
ankatiyar
ankatiyar approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the python_version specification might still be needed, LGTM otherwise!

databricks-iris/{{ cookiecutter.repo_name }}/pyproject.toml Outdated Show resolved Hide resolved
databricks-iris/{{ cookiecutter.repo_name }}/requirements.txt Outdated Show resolved Hide resolved
@ravi-kumar-pilla
address PR comments
3fbb399 
Signed-off-by: ravi_kumar_pilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@ankatiyar ankatiyar ankatiyar approved these changes

@lrcouto lrcouto Awaiting requested review from lrcouto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.13 support
3 participants
@ravi-kumar-pilla @astrojuanlu @ankatiyar