Pin Pip and fix lint e2e tests #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
3 tasks
ankatiyar
approved these changes
Dec 20, 2023
astrojuanlu
approved these changes
Dec 20, 2023
Comment on lines
+18
to
+59
| def run( | ||
| cmd: list | str, split: bool = True, print_output: bool = False, **kwargs: Any | ||
| ) -> subprocess.CompletedProcess: | ||
| """Run a shell command. | ||
|
|
||
| Args: | ||
| cmd: A command string, or a command followed by program | ||
| arguments that will be submitted to Popen to run. | ||
|
|
||
| split: Flag that splits command to provide as multiple *args | ||
| to Popen. Default is True. | ||
|
|
||
| print_output: If True will print previously captured stdout. | ||
| Default is False. | ||
|
|
||
| **kwargs: Extra options to pass to subprocess. | ||
|
|
||
| Example: | ||
| :: | ||
| "ls" | ||
| "ls -la" | ||
| "chmod 754 local/file" | ||
|
|
||
| Returns: | ||
| Result with attributes args, returncode, stdout and stderr. | ||
|
|
||
| """ | ||
| if isinstance(cmd, str) and split: | ||
| cmd = shlex.split(cmd) | ||
| result = subprocess.run(cmd, input="", capture_output=True, **kwargs) # noqa: PLW1510 | ||
| result.stdout = result.stdout.decode("utf-8") | ||
| result.stderr = result.stderr.decode("utf-8") | ||
| if print_output: | ||
| print(result.stdout) | ||
| return result | ||
|
|
||
| def call(cmd, env): | ||
| res = run(cmd, env=env) | ||
| if res.returncode: | ||
| print(res.stdout) | ||
| print(res.stderr) | ||
| assert False |
There was a problem hiding this comment.
Is this more or less check_output? https://docs.python.org/3/library/subprocess.html#subprocess.check_output
There was a problem hiding this comment.
This chunk of code is borrowed from Kedro repo.
| "-m", | ||
| "pip", | ||
| "install", | ||
| "-U", |
There was a problem hiding this comment.
nit: No need to do -U if installing a specific version?
|
Merging anyway, we can address the comments later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
kedro lintNoted pip version is set twice. Previously pip version are sometimes in 23.3 or 21 depending on the OS/tests combo.
How has this been tested?
Checklist