Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasets): introduce PolarsExcelDataset for high-performance multi-sheet Excel integration in KedroFeature/polars excel dataset #1002

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Stephanieewelu
Copy link

Introducing PolarsExcelDataset for high-performance multi-sheet Excel integration in KedroFeature/polars excel dataset

Stephanieewelu and others added 2 commits February 7, 2025 04:11
Implementation of Polar Dataset

Signed-off-by: Stephanie Ewelu <[email protected]>
@merelcht
Copy link
Member

merelcht commented Feb 7, 2025

Hi @Stephanieewelu, thank you for opening this contribution PR! I see some of the builds are failing, shout if you need some help from the team to get them to pass 🙂

I want to double check if you'd like to contribute this dataset as experimental or to the core (which is a stricter review process)? You can read more about that here: https://github.com/kedro-org/kedro-plugins/blob/main/kedro-datasets/CONTRIBUTING.md#difference-between-core-and-experimental-datasets

@Stephanieewelu
Copy link
Author

@merelcht thank you very much. Yes, I need help for my contribution to pass. Keeps failing.
image

@Stephanieewelu
Copy link
Author

@merelcht I want to contribute to experimental.

@merelcht
Copy link
Member

@merelcht I want to contribute to experimental.

Okay that simplifies things a bit! You'll have to move your new dataset to kedro_datasets_experimental. Then I suggest having a look at https://github.com/kedro-org/kedro-plugins/blob/main/kedro-datasets/CONTRIBUTING.md#ci--cd-and-running-checks-locally, to get the lint and test builds to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants