Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the documentation on github-runner.md to use correct variable name for githubApiURL #1294

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

zerola
Copy link
Contributor

@zerola zerola commented Jan 16, 2024

The variable name should be githubApiURL, not the githubAPIURL as per the line below:

https://github.com/kedacore/keda/blob/main/pkg/scalers/github_runner_scaler.go#L412

This PR extends the PR #1261 for other versions of above mentioned issue as was requested, but activity on the PR got stalled.
Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@zerola zerola requested a review from a team as a code owner January 16, 2024 14:54
Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 702e615
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65a6996a22a8150008b684d5
😎 Deploy Preview https://deploy-preview-1294--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@zerola zerola force-pushed the github-runner-fix-doc branch from 30c2f57 to 702e615 Compare January 16, 2024 14:57
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 675cdd9 into kedacore:main Jan 16, 2024
8 checks passed
@zerola zerola deleted the github-runner-fix-doc branch January 16, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants