DMD-33 bucket refresh fix column data types #181
Conversation
vojtabiberle
force-pushed
the
vb-DMD-33-bucket-refresh-fix-column-data-types
branch
5 times, most recently
from
4c6751e to
b29ee29
Compare
vojtabiberle
force-pushed
the
vb-DMD-33-bucket-refresh-fix-column-data-types
branch
from
b29ee29 to
9222584
Compare
| WHEN DATA_TYPE IN ('BINARY', 'VARBINARY') THEN | ||
| 'BINARY' | ||
|
|
||
| -- Default case for all other types as they are mapped by DESC TABLE direcly to themself |
There was a problem hiding this comment.
premyslim jeste o dalsich datatypech (napr FLOAT...), ale asi to nechme tak
There was a problem hiding this comment.
pravda, mapují se všechny na FLOAT: https://docs.snowflake.com/en/sql-reference/data-types-numeric#examples-of-floating-point-data-types-in-a-table
To tam ještě přidám
There was a problem hiding this comment.
ne, to je prece v poradku, je to shodne s DESC table -> bude to float
There was a problem hiding this comment.
ta myslenka byla v tom, ze jsi identifikoval nejake datatypy, ktere v te query resis. Ale neumime rict, jestli se vsechny ostatni pak chovaji "spravne" - tzn muzou defaultovat na to co o sobe opradvu rikaji
There was a problem hiding this comment.
Jo máš pravdu, float je OK.
Asi by teoreticky mohl bejt problém s novým data typem nebo pokud to snowflake změni.
Rád bych pak napsal test, který to bude porovnávat, ale asi až to celé doklepnu tak jako další udržovací task.
There was a problem hiding this comment.
vojtabiberle
force-pushed
the
vb-DMD-33-bucket-refresh-fix-column-data-types
branch
from
d5e63a1 to
798c3af
Compare
vojtabiberle
deleted the
vb-DMD-33-bucket-refresh-fix-column-data-types
branch
Jira: DMD-33
Connection PR: https://github.com/keboola/connection/pull/5415
SAPI PR: keboola/storage-api-php-client#1439
Changes:
- add length & precision for data types