CT-1896 test correctly TreatValuesAsNull on BQ #1428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajca
commented
Dec 4, 2024
| @@ -52,8 +52,7 @@ public function testImportTreatValuesAsNull( | |||
| return $row; | |||
| }, $data); | |||
|
|
|||
| $this->assertEqualsCanonicalizing($expectedData, $data); | |||
|
|
|||
| $this->assertArraySameSorted($expectedData, $data, 0); | |||
There was a problem hiding this comment.
Tady to nevidělo rozdíl mezi null a ''
zajca
commented
Dec 4, 2024
| @@ -98,7 +97,7 @@ public function treatValuesAsNullData(): Generator | |||
| 1 => [ | |||
| 0 => 31, | |||
| 1 => 'belarus', | |||
| 2 => '', | |||
| 2 => null, | |||
There was a problem hiding this comment.
tady byl špatně assert ale test procházal
zajca
commented
Dec 4, 2024
| @@ -109,6 +108,30 @@ public function treatValuesAsNullData(): Generator | |||
| ], | |||
| ], | |||
| ]; | |||
| yield 'string' => [ | |||
There was a problem hiding this comment.
nový case změny znaku 'b' za null
|
|
zajca
commented
Dec 4, 2024
| }; | ||
| usort($expected, $comparison); | ||
| usort($actual, $comparison); | ||
| $this->assertSame($expected, $actual, $message); |
There was a problem hiding this comment.
Nový assert dělá same ne equals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: CT-1896
KBC: XXX
Before asking for review make sure that:
Checklist
Release