Disable BQ on valuesBy*

keboola · Jan 27, 2025 · 076c5d7 · 076c5d7
1 parent 2d72aee
commit 076c5d7
Showing 1 changed file with 18 additions and 3 deletions.
diff --git a/tests/Backend/CommonPart1/DeleteRowsTest.php b/tests/Backend/CommonPart1/DeleteRowsTest.php
@@ -30,9 +30,12 @@ public function testTableDeleteRowsByFilter(array $filterParams, array $expected
     {
         $importFile = __DIR__ . '/../../_data/users.csv';
         $tableId = $this->_client->createTableAsync($this->getTestBucketId(self::STAGE_IN), 'users', new CsvFile($importFile));
+        $tableInfo = $this->_client->getTable($tableId);
+        if ($this->isBigqueryWithNewDeleteRows($tableInfo['bucket']['backend'], $filterParams)) {
+            $this->markTestSkipped('BQ does not new params of valuesBy* yet');
+        }
 
         $this->_client->deleteTableRows($tableId, $filterParams);
-        $tableInfo = $this->_client->getTable($tableId);
 
         $data = $this->_client->getTableDataPreview($tableId);
 
@@ -63,9 +66,11 @@ public function testTableDeleteRowsByFilterAsQuery(array $filterParams, array $e
     {
         $importFile = __DIR__ . '/../../_data/users.csv';
         $tableId = $this->_client->createTableAsync($this->getTestBucketId(self::STAGE_IN), 'users', new CsvFile($importFile));
-
-        $this->_client->deleteTableRowsAsQuery($tableId, $filterParams);
         $tableInfo = $this->_client->getTable($tableId);
+        if ($this->isBigqueryWithNewDeleteRows($tableInfo['bucket']['backend'], $filterParams)) {
+            $this->markTestSkipped('BQ does not new params of valuesBy* yet');
+        }
+        $this->_client->deleteTableRowsAsQuery($tableId, $filterParams);
 
         $data = $this->_client->getTableDataPreview($tableId);
 
@@ -75,6 +80,16 @@ public function testTableDeleteRowsByFilterAsQuery(array $filterParams, array $e
         $this->assertArrayEqualsSorted($expectedTableContent, $parsedData, 0);
     }
 
+    // because BQ does not support valuesByTableInStorage / valuesByTableInWorkspace yet/. Tmp fix
+    private function isBigqueryWithNewDeleteRows(string $backendName, array $filterParams): bool
+    {
+        return $backendName === 'bigquery' &&
+            array_key_exists('whereFilters', $filterParams) &&
+            count($filterParams) > 0 &&
+            (array_key_exists('valuesByTableInStorage', $filterParams['whereFilters'][0]) || array_key_exists('valuesByTableInWorkspace', $filterParams['whereFilters'][0])
+            );
+    }
+
     public function testDeleteRowsMissingValuesShouldReturnUserError(): void
     {
         $importFile = __DIR__ . '/../../_data/users.csv';