Backup to google storage #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrajodas
force-pushed
the
PST-2374-ondra
branch
3 times, most recently
from
006c52e to
bbc5c24
Compare
ErikZigo
reviewed
Jan 21, 2025
ErikZigo
reviewed
Jan 21, 2025
tests/GcsBackupTest.php
Outdated
| 'sapi-php-test.json', | ||
| $targetData['configurations']['keboola.snowflake-transformation'], | ||
| ); | ||
| self::assertStringContainsString( |
There was a problem hiding this comment.
Protoze tam je ta signed url a pri chybe by se to vypsalo do logu v textu vyjimky, upravil bych to tak, aby tam bylo
self::assertTrue() a vevnitr porovnavat jestli jeden string obsahuje druhej.
There was a problem hiding this comment.
1/ ok, upraveno, ale ->
2/ a to něčemu vadí že by se vypsala ta URL? tak by si někdo stáhl obsah testovací konfigurace - to mi je asi celkem jedno
ondrajodas
force-pushed
the
PST-2374-ondra
branch
from
e776fb7 to
ae870e1
Compare
|
ještě jsem to tu rebasnul |
ErikZigo
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://keboola.atlassian.net/browse/PST-2374
backup je pak pro to nachystaný tady - keboola/app-project-backup#57