Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Commit pipeline's SHA next to the image tag for Argo deployments #2201

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

wokoman
Copy link
Contributor

@wokoman wokoman commented Jan 8, 2025

Jira: ST-2598

This is enablement allowing for Datadog annotation to show from which commit has been the deployed image actually built. Context: https://keboolaglobal.slack.com/archives/C055WKPHYSD/p1732634259450249?thread_ts=1732550113.610629&cid=C055WKPHYSD

When set to true, this flag will commit the SHA next to the image tag, like so. This can then be referenced for the Datadog in the annotations.

This is in tandem with these implementations:

Copy link
Contributor

@Matovidlo Matovidlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wokoman wokoman force-pushed the michal-st-2598-commit-sha-argo-cd branch from c9776d6 to e4875c8 Compare January 8, 2025 14:21
@Matovidlo Matovidlo force-pushed the michal-st-2598-commit-sha-argo-cd branch from e4875c8 to 1dc6f6c Compare January 9, 2025 09:19
@jachym-tousek-keboola jachym-tousek-keboola merged commit 4bfa449 into main Jan 9, 2025
12 checks passed
@jachym-tousek-keboola jachym-tousek-keboola deleted the michal-st-2598-commit-sha-argo-cd branch January 9, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants