Add migrate secrets params

keboola · Mar 26, 2024 · d6edfa6 · d6edfa6
1 parent 71d7e4f
commit d6edfa6
Show file tree

Hide file tree

Showing 5 changed files with 42 additions and 7 deletions.
diff --git a/src/Component.php b/src/Component.php
@@ -75,7 +75,8 @@ protected function run(): void
             $config->getSourceProjectUrl(),
             $config->getSourceProjectToken(),
             $config->directDataMigration(),
-            $logger
+            $logger,
+            $config->shouldMigrateSecrets(),
         );
         $migrate->run();
 

diff --git a/src/Config.php b/src/Config.php
@@ -4,6 +4,7 @@
 
 namespace Keboola\AppProjectMigrate;
 
+use InvalidArgumentException;
 use Keboola\Component\Config\BaseConfig;
 
 class Config extends BaseConfig
@@ -28,4 +29,14 @@ public function directDataMigration(): bool
     {
         return $this->getValue(['parameters', 'directDataMigration']);
     }
+
+    public function shouldMigrateSecrets(): bool
+    {
+        return $this->getValue(['parameters', 'migrateSecrets']);
+    }
+
+    public function getManageToken(): ?string
+    {
+        return $this->getValue(['parameters', '#manageToken']);
+    }
 }
diff --git a/src/ConfigDefinition.php b/src/ConfigDefinition.php
@@ -26,6 +26,13 @@ protected function getParametersDefinition(): ArrayNodeDefinition
                     ->cannotBeEmpty()
                 ->end()
                 ->booleanNode('directDataMigration')->defaultTrue()->end()
+                ->booleanNode('migrateSecrets')->defaultFalse()->end()
+                ->scalarNode('#manageToken')->end()
+            ->end()
+            ->validate()
+                ->ifTrue(fn($values) =>
+                    isset($values['migrateSecrets']) && $values['migrateSecrets'] && !isset($values['#manageToken']))
+                ->thenInvalid('Parameter "#manageToken" is required when "migrateSecrets" is set to true.')
             ->end()
         ;
         // @formatter:on

diff --git a/src/Migrate.php b/src/Migrate.php
@@ -26,20 +26,24 @@ class Migrate
 
     private bool $directDataMigration;
 
+    private bool $migrateSecrets;
+
     public function __construct(
         JobRunner $sourceJobRunner,
         JobRunner $destJobRunner,
         string $sourceProjectUrl,
         string $sourceProjectToken,
         bool $directDataMigration,
-        LoggerInterface $logger
+        LoggerInterface $logger,
+        bool $migrateSecrets
     ) {
         $this->sourceJobRunner = $sourceJobRunner;
         $this->destJobRunner = $destJobRunner;
         $this->sourceProjectUrl = $sourceProjectUrl;
         $this->sourceProjectToken = $sourceProjectToken;
         $this->directDataMigration = $directDataMigration;
         $this->logger = $logger;
+        $this->migrateSecrets = $migrateSecrets;
     }
 
     public function run(): void
@@ -180,6 +184,7 @@ private function getRestoreConfigData(array $restoreCredentials): array
                         '#sessionToken' => $restoreCredentials['credentials']['sessionToken'],
                     ],
                     'useDefaultBackend' => true,
+                    'restoreConfigs' => $this->migrateSecrets === false,
                 ],
             ];
         } elseif (isset($restoreCredentials['credentials']['connectionString'])) {
@@ -190,6 +195,7 @@ private function getRestoreConfigData(array $restoreCredentials): array
                         '#connectionString' => $restoreCredentials['credentials']['connectionString'],
                     ],
                     'useDefaultBackend' => true,
+                    'restoreConfigs' => $this->migrateSecrets === false,
                 ],
             ];
         } else {

diff --git a/tests/phpunit/MigrateTest.php b/tests/phpunit/MigrateTest.php
@@ -55,7 +55,13 @@ public function testMigrateSuccess(
             [
                 Config::PROJECT_RESTORE_COMPONENT,
                 [
-                    'parameters' => array_merge($expectedCredentialsData, ['useDefaultBackend' => true]),
+                    'parameters' => array_merge(
+                        $expectedCredentialsData,
+                        [
+                            'useDefaultBackend' => true,
+                            'restoreConfigs' => true,
+                        ]
+                    ),
                 ],
             ],
         ];
@@ -111,7 +117,8 @@ public function testMigrateSuccess(
             $sourceProjectUrl,
             $sourceProjectToken,
             $migrateDataOfTablesDirectly,
-            new NullLogger()
+            new NullLogger(),
+            false,
         );
         $migrate->run();
     }
@@ -146,7 +153,8 @@ public function testShouldFailOnSnapshotError(): void
             'xxx',
             'yyy',
             false,
-            new NullLogger()
+            new NullLogger(),
+            false,
         );
         $migrate->run();
     }
@@ -184,7 +192,8 @@ public function testShouldFailOnRestoreError(): void
             'xxx',
             'yyy',
             false,
-            new NullLogger()
+            new NullLogger(),
+            false,
         );
         $migrate->run();
     }
@@ -217,7 +226,8 @@ public function testCatchSyrupClientException(): void
             'xxx',
             'yyy',
             false,
-            new NullLogger()
+            new NullLogger(),
+            false,
         );
 
         $this->expectException(UserException::class);