Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQs corrections #494

Closed
wants to merge 10 commits into from
Closed

Conversation

Sumitwarrior7
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

FAQs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kcl-lang-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 9:32am

@Sumitwarrior7
Copy link
Contributor Author

Sumitwarrior7 commented Dec 25, 2024

Some codes were giving errors because of some logical errors and typos:-

Due to precedence issues of OR and + operator :
Screenshot from 2024-12-25 01-06-01

Incorrect use of index :
Screenshot from 2024-12-25 13-15-25

Col == 0 is an issue
Screenshot from 2024-12-25 13-33-29

Some other typos are also there

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa
Copy link
Contributor

He1pa commented Dec 26, 2024

There is one commit incorrectly signed off. This means that the author of this commit failed to include a Signed-off-by line in the commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name [email protected] in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.

Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

You are the only author of the commits in this branch
You are absolutely certain nobody else is doing any work based upon this branch
There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)
To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~2 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin faq-corrections

@zong-zhe
Copy link
Contributor

Hi @Sumitwarrior7 😄

Good Job! DCO github action is failed, you can follow this https://www.secondstate.io/articles/dco/ to fix.

Sumitwarrior7 and others added 10 commits December 26, 2024 14:40
Signed-off-by: Sumitwarrior7 <[email protected]>
Signed-off-by: he1pa <[email protected]>
Signed-off-by: Sumitwarrior7 <[email protected]>
Signed-off-by: he1pa <[email protected]>
Signed-off-by: Sumitwarrior7 <[email protected]>
Signed-off-by: zongz <[email protected]>
Signed-off-by: Sumitwarrior7 <[email protected]>
Signed-off-by: zongz <[email protected]>
Signed-off-by: Sumitwarrior7 <[email protected]>
Signed-off-by: zongz <[email protected]>
Signed-off-by: Sumitwarrior7 <[email protected]>
Signed-off-by: zongz <[email protected]>
Signed-off-by: Sumitwarrior7 <[email protected]>
Signed-off-by: Sumitwarrior7 <[email protected]>
Signed-off-by: zongz <[email protected]>
Signed-off-by: Sumitwarrior7 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants