-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to typesense as search backend #374
Comments
Just my two cents, the priority should be reordered. Just create for spesific page first, then we can think about centralized later. |
Agreed, Mas @mazipan. I have updated the task list accordingly. Thank you for creating this epic with beneficial documentation, Mas @famasya! |
Well, I've also written a quick implementation of this approach in this commit from this PS: pardon for bad styling, :)) |
Friendly reminder that this issue need to be expedited due to the reasons mentioned in #197 (comment):
|
I just don't think we need this kind of Search Library in the front-end 😂 But ya, from our previous decision we will go with the TypeSense. Currently, I don't know, what can I help on this. So we need to work with many developer in a single PR? |
Sorry, I wasn't feeling well so I coudn't work on it. Just pushed #401 update. First, for the setting as I mentioned here #401 (comment) And for testing, since the data is from index, mock data can't be initialized and passed as props. Tried to find mock for typesense/algolia but still can't find it so I change the test using hardcoded text -> could result in failed test if the data is updated. |
I think we need to add more developer to help @ekamuktia. @zainfathoni can you help on the testing part once we get a full flow? I will try to take a look the PR tomorrow, looking if I can help on this 😂 We have a good start from @ekamuktia |
Sure, I'll try to unblock the testing part later today. 👌 |
Overview
As discussed at #290, we can move to typesense to gain instant-search capability. The search experience should be easier and faster for the user, as it provides typo-tolerant and near real-time search results.
Implementation details
Typesense server will hosted by trustmedis and its contents are crawled hourly by wbw-gsheets-crawler. As discussed by @zainfathoni , there are three indices for now:
wbw-gsheets-database
wbw-gsheets-faq
wbw-gsheets-telemedicine
More indices can be added by making MR into crawler repository.
Fortunately, we have typesense-instantsearch-adapter as a wrapper of Algolia's instantsearch react components. No need to write components from scratch.
API KEY information
CLICK ME
Code
A dirty implementation to instantiate typesense class should be looked like:
Current Tasks
Unit & integration tests
FAQ
page to avoid regressions #376Provinces
page to avoid regressions #382ProvincesPage
extensively #458Province
page to avoid regressions #413ProvincePage
extensively #468Contact
page to avoid regressions #383ContactPage
extensively #459End-to-end tests
FAQ
page to avoid regressions #380Provinces
page to avoid regressions #381Contact
page to avoid regressions #414Implementation
FAQ
page into the Typesense backend #377Provinces
page into the Typesense backend #378The text was updated successfully, but these errors were encountered: