Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fetch-wbw back to mirror-box again once the mirror-box is updated #412

Closed
Tracked by #236
zainfathoni opened this issue Jul 25, 2021 · 1 comment · Fixed by #416 or #481
Closed
Tracked by #236

Revert fetch-wbw back to mirror-box again once the mirror-box is updated #412

zainfathoni opened this issue Jul 25, 2021 · 1 comment · Fixed by #416 or #481
Assignees
Labels
dx Developer Experience

Comments

@zainfathoni
Copy link
Member

@zainfathoni the netlify build will always fail since I added a new static property slug when generating data with etc/fetchers. The new format isn't generated when netlify executes yarn build which will cause provinceSlug to be undefined thus causing next build to throw errors (as it expects the slug to be at least null or empty string).

Can we make sure that the app fetches fresh data before any build?

You can temporarily revert this line into using the fetch-wbw script again, so that we can merge this PR to the main branch.
Once it has been merged to the main branch, the mirror-box script gets the latest version of your fetch-wbw.js implementation after a few minutes. After that, you can raise another PR to revert your changes to use the mirror-box again. 😅

I know it's a hassle, but I don't think we need to optimize this workflow, because #374 is coming soon anyway, and it will render both fetch-wbw and mirror-box useless. 😅

Originally posted by @zainfathoni in #361 (comment)

@zainfathoni zainfathoni added the dx Developer Experience label Jul 25, 2021
@zainfathoni zainfathoni mentioned this issue Jul 25, 2021
14 tasks
@zainfathoni
Copy link
Member Author

Reopening this issue due to #469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience
Projects
None yet
1 participant