Golang cgo bindings and CI tests #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the Golang bindings originally written by David Stainton for the Katzenpost Mixnet fork and uses the latest SPHINCS+ reference implementation. This branch enhances the bindings to parameterize building, and to perform comprehensive testing for all parameter sets on GNU/Linux, MacOS, and Windows.
david415
commented
May 12, 2024
|
|
||
| // Name returns the string naming of the current | ||
| // Sphincs+ that this binding is being used with. | ||
| SignatureName = params.Name() |
There was a problem hiding this comment.
I'd say it's fine if it works... this variable assignment. Sometimes golang programmers will do that inside an init function but i'm not clear on when that's necessary.
david415
commented
May 12, 2024
| return nil | ||
| } | ||
|
|
||
| // Verify checks whether the given signature is valid. |
There was a problem hiding this comment.
Is this may fault? let's remove this commented code section if it's not used.
| @@ -0,0 +1,5 @@ | |||
| //go:build sphincs_haraka_128f | |||
| @@ -0,0 +1,139 @@ | |||
| //go:build cgo && ((linux && amd64) || (darwin && amd64) || (darwin && arm64) || (windows && amd64)) && (sphincs_haraka_128f || sphincs_haraka_128s || sphincs_haraka_192f || sphincs_haraka_192s || sphincs_haraka_256f || sphincs_haraka_256s || sphincs_sha2_128f || sphincs_sha2_128s || sphincs_sha2_192f || sphincs_sha2_192s || sphincs_sha2_256f || sphincs_sha2_256s || sphincs_shake_128f || sphincs_shake_128s || sphincs_shake_192f || sphincs_shake_192s || sphincs_shake_256f || sphincs_shake_256s) | |||
There was a problem hiding this comment.
cool... looks impressive
|
|
||
| package sphincsplus | ||
|
|
||
| //#cgo amd64 LDFLAGS: -L./ |
| windows-build-and-test-golang: | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: |
There was a problem hiding this comment.
now that's a large matrix!
| - robust | ||
| OS: ["ubuntu-latest", "macos-latest"] | ||
| go-version: ["1.20"] | ||
| #go-version: ["1.22.x"] |
There was a problem hiding this comment.
let's remove this commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Golang bindings originally written by David Stainton for the Katzenpost Mixnet fork and uses the latest SPHINCS+ reference implementation. This branch enhances the bindings to parameterize building, and to perform comprehensive testing for all parameter sets on GNU/Linux, MacOS, and Windows.