Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig: Use lazyDependencies #48

Merged
merged 5 commits into from
Jan 9, 2025
Merged

zig: Use lazyDependencies #48

merged 5 commits into from
Jan 9, 2025

Conversation

kassane
Copy link
Owner

@kassane kassane commented Jan 7, 2025

closes #47

Optional fetch dependency

@kassane kassane added the enhancement New feature or request label Jan 7, 2025
@kassane kassane requested a review from floooh January 7, 2025 18:09
@kassane

This comment was marked as outdated.

@kassane kassane marked this pull request as ready for review January 8, 2025 16:38
@kassane kassane merged commit 5de2dfe into main Jan 9, 2025
3 checks passed
@kassane kassane deleted the lazydeps branch January 9, 2025 17:25
@kassane
Copy link
Owner Author

kassane commented Jan 9, 2025

The error that occurred in MacOS was unexpected after the merge (two days of difference between PR and merge commit).

edit:

Why dub-artifact call libsokol (zig-out and global-zig-cache paths)?

duplicate symbol '_sapp_d3d11_get_render_view' in:
    /Users/runner/work/sokol-d/sokol-d/zig-out/lib/libsokol.a[3](sokol_app.o)
    /Users/runner/.cache/zig/o/0edd866490c6243cf804aae7bd00ad6c/libsokol.a[3](sokol_app.o)
duplicate symbol '_sapp_gl_get_framebuffer' in:
    /Users/runner/work/sokol-d/sokol-d/zig-out/lib/libsokol.a[3](sokol_app.o)
    /Users/runner/.cache/zig/o/0edd866490c6243cf804aae7bd00ad6c/libsokol.a[3](sokol_app.o)

@kassane
Copy link
Owner Author

kassane commented Jan 9, 2025

The error that occurred in MacOS was unexpected after the merge (two days of difference between PR and merge commit).

Why dub-artifact call libsokol (zig-out and global-zig-cache paths)?

Fixed b52ef71
dub uses zig-out path and zig-build only links cache path together and ldc2/ldmd2 access both in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build.zig: Make optional fetch dependencies
1 participant