Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SDL3 include autoconf #261

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

rakslice
Copy link

Fix so that the autoconf modification of the SDL3 include path works on systems where the default shell is not bash (or other shell that has this += operator)

@kanjitalk755
Copy link
Owner

Could you also include BasiliskII/src/Windows/configure.ac and SheepShaver/src/{Unix,Windows}/configure.ac in this PR?

@rakslice
Copy link
Author

I made the change also for BasiliskII/src/Windows/configure.ac and SheepShaver/src/{Unix,Windows}/configure.ac.

For Windows it should not really be necessary since the build environment is always MSYS2?

What is the situation with SDL3 support in Windows? I see MSYS2 doesn't have a packaged sdl3 for mingw32. Do you just build it from source?

@kanjitalk755 kanjitalk755 merged commit 6c30a1a into kanjitalk755:master Jan 31, 2025
@kanjitalk755
Copy link
Owner

For Windows it should not really be necessary since the build environment is always MSYS2?

Ah, it may not be necessary for MSYS2.

What is the situation with SDL3 support in Windows? I see MSYS2 doesn't have a packaged sdl3 for mingw32. Do you just build it from source?

I was building SDL3 from source.
The official release (3.2.0) came out last week, so I think it will be supported in MSYS2 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants