Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve options to configure aws rds secret and region #3390

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hairyhum
Copy link
Contributor

Change Overview

Change RDS example blueprint to use region from the configmap and specify secret in a blueprint (as referenced in the configmap) instead of requiring options and secret reference in the actionset.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Change RDS example blueprint to use region from the configmap and specify secret
in a blueprint (as referenced in the configmap) instead of requiring options and
secret reference in the actionset.

Signed-off-by: Daniil Fedotov <[email protected]>
@hairyhum
Copy link
Contributor Author

TODO: Still need to verify with RDS setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant