fix: copy "container" override to "background" and "output" overrides for MultiContainerRun #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
hairyhum
force-pushed
the
podoverride-multicontainer
branch
2 times, most recently
from
cf71767 to
74ecb76
Compare
… for MultiContainerRun Since MultiContainerRun uses different container names than "container", when users set "container" override they intend to set "worker container" override. This change will copy override spec from "container" container to worker containers. This is a hotfix to support these users until we have better API for passing override via actionset. Signed-off-by: Daniil Fedotov <[email protected]>
hairyhum
force-pushed
the
podoverride-multicontainer
branch
from
74ecb76 to
cb32f02
Compare
|
Tested as a part of #3286 |
Shrekster
approved these changes
Feb 26, 2025
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Since MultiContainerRun uses different container names than "container", when users set "container" override they intend to set "worker container" override.
This change will copy override spec from "container" container to worker containers.
NOTE This is a hotfix to support these users until we have better API for passing override via actionset (#3320).
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan