Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend database pool options #1026

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

rmn-boiko
Copy link
Contributor

@rmn-boiko rmn-boiko commented Jan 6, 2025

Description

Checklist before requesting a review

@rmn-boiko rmn-boiko self-assigned this Jan 6, 2025
@rmn-boiko rmn-boiko changed the title Feat/extend pool options Extend pool options Jan 6, 2025
@rmn-boiko rmn-boiko changed the title Extend pool options Extend database pool options Jan 6, 2025
@sergiimk
Copy link
Member

sergiimk commented Jan 6, 2025

LGTM, but consider modifying the PR description not to close the linked ticket until these options are also exposed in api-server's config

Copy link
Contributor

@zaychenko-sergei zaychenko-sergei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think it can be supported by MySQL easily, for consistency.
  2. For SQLite, think of some configuration error mechanism or a warning that these settings are ignored.

@rmn-boiko
Copy link
Contributor Author

  1. For SQLite, think of some configuration error mechanism or a warning that these settings are ignored.

Such as these configurations are optional do we really need to add warnings for Sqlite if they are not presented?

@rmn-boiko rmn-boiko force-pushed the feat/extend-pool-options branch from 6a5eb4a to 387a398 Compare January 8, 2025 11:14
@rmn-boiko rmn-boiko force-pushed the feat/extend-pool-options branch from 387a398 to 1733f72 Compare January 9, 2025 08:37
@rmn-boiko rmn-boiko force-pushed the feat/extend-pool-options branch from 1733f72 to f6e24ce Compare January 9, 2025 08:38
@zaychenko-sergei zaychenko-sergei merged commit 5cf398c into master Jan 9, 2025
@zaychenko-sergei zaychenko-sergei deleted the feat/extend-pool-options branch January 9, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants