Fix/issue#166: 모임 목록 조회 시 404 예외 발생 문제 해결 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results79 tests 79 ✅ 8s ⏱️ Results for commit dde4442. ♻️ This comment has been updated with latest results. |
1 task
Lucerna00
reviewed
Nov 11, 2024
Comment on lines
51
to
54
| @DisplayName("모임의 isClosed `true`상태인 데이터를 불러온다") | ||
| void testFindByIsClosed_withOpenTeam() { | ||
| // given | ||
| Boolean isClosed = false; |
There was a problem hiding this comment.
P2: 모임 isClosed가 false인 상태일 때의 테스트 같습니다
| @Query("SELECT t FROM Team t " + | ||
| "JOIN FETCH t.teamMemberList tm " + | ||
| "JOIN FETCH tm.member " + | ||
| "JOIN t.teamMemberList tm " + | ||
| "WHERE tm.member.id = :memberId " + | ||
| "AND t.isClosed = :isClosed") | ||
| List<Team> findByIsClosed(@Param("memberId") Long memberId, Boolean isClosed); |
There was a problem hiding this comment.
P1: 이전 PR 머지 후 제 로컬 환경에선 Either use @Param on all parameters except Pageable and Sort typed once, or none at all 에러가 발생했습니다. isClosed에도 @Param("isClosed")가 필요할 것 같습니다.
There was a problem hiding this comment.
확인했습니다. JPQL 쓰는 것들은 가능하면 Param은 무조건 사용하는게 좋겠네요
This was referenced Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
🔍 원인
✨ 작업 내용
🔍 참고사항
🐞현재 버그
#️⃣ 연관 이슈(Git Close)
close #166
😊 리뷰 규칙을 지킵시다
코드 리뷰는
Pn룰에 따라 작성하기.Reviewer가 피드백을 남길 때 Assignee에게 얼마나 해당 피드백에 대해 강조하고 싶은 지 표현하기 위한 규칙입니다.
P1: 꼭 반영해 주세요 (Request Changes) - 이슈가 발생하거나 취약점이 발견되는 케이스 등P2: 반영을 적극적으로 고려해 주시면 좋을 것 같아요 (Comment)P3: 이런 방법도 있을 것 같아요~ 등의 사소한 의견입니다 (Chore)