Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

강원대 FE_정다연 2주차 STEP2, 3 #53

Open
wants to merge 33 commits into
base: dandamdandam
Choose a base branch
from
Open

강원대 FE_정다연 2주차 STEP2, 3 #53

wants to merge 33 commits into from

Conversation

dandamdandam
Copy link

@dandamdandam dandamdandam commented Jul 5, 2024 •
edited
Loading

dandamdandam and others added 29 commits July 3, 2024 14:52
@dandamdandam
style: change a tab size 2 to 4
98339e6
@dandamdandam
feat: add footer component
1076afa
@dandamdandam
style: adjust prettier
9298084 
prettier --write --config ./.prettierrc './src/**/*.tsx'
@dandamdandam
feat: add Header UI
021176c
@dandamdandam
feat: add route(react-router-dom)
89a439e 
header ui가 안보여서 추가로 고쳤습니다..
@dandamdandam
feat: add themeList (mainpage)
3faa1eb
@dandamdandam
feat: add themeBtn (mainpage)
25a75ff
@dandamdandam
feat: modify reset.css
0629ca5 
link(a) 디자인 바꿈
@dandamdandam
refactor: split main(page) into main and themeList
11adaee
@dandamdandam
feat: add targetTypeFilter (mainPage)
951443e
@dandamdandam
refactor: move FilterType.ts
1a60619
@dandamdandam
feat: modify theme style
14c4c2e
@dandamdandam
feat: add rankTypeFilter (mainPage)
e170617
@dandamdandam
feat: add rankingItem List (mainPage)
c067b72
@dandamdandam
feat: add toggle detail of rankingItems list (mainPage)
d182d67
@dandamdandam
feat: complete mainPage layout and styling
e8bb0eb
@dandamdandam
fix: theme routing error & add error handling
ac37a25 
themeKey를 한국어 그대로 사용했더니 특수문자까지 라우팅하는 문제가 생김. 사용자에게 보여주는 표현은 label로 두어 해결
@dandamdandam
feat: add header section (ThemePage)
ebca827
@dandamdandam
feat: add item list section (ThemePage)
b9b0a0e
@dandamdandam
feat: header button router (Header Comp)
6c4babb
@dandamdandam
feat: add login page
b5ac02e
@dandamdandam
feat: add my-account page
8b6ab4c
@dandamdandam
docs: update readme
0b0c146
@dandamdandam
Update README.md
4ee8bbe
@dandamdandam
style: change sessionStorageKey user to authToken
b081fbc
@dandamdandam
feat: add AuthContext
7f2357b
@dandamdandam
feat: check auth using AuthContext
3301f37
@dandamdandam
docs: update readme
560ecc2
@dandamdandam
feat: update README for step3
123769f
@dandamdandam dandamdandam changed the title 강원대 FE_정다연 2주차 STEP2 강원대 FE_정다연 2주차 STEP2, 3 Jul 5, 2024
@dandamdandam dandamdandam mentioned this pull request Jul 5, 2024
Merged
@lazy-sky lazy-sky changed the base branch from main to dandamdandam July 7, 2024 06:58
lazy-sky
lazy-sky requested changes Jul 7, 2024
View reviewed changes
Copy link

@lazy-sky lazy-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컨텍스트 관리 부분을 제외하면 이전 pr에서 크게 변화한 부분은 없는 거 같네요. 이전 pr에서 리뷰 및 피드백 진행하고 머지하도록 하겠습니다~

다른 궁금하신 부분 있으시면 댓글로 남겨주세요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazy-sky lazy-sky lazy-sky requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dandamdandam @lazy-sky