강원대_Android_이아림_3주차과제_STEP2 #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented OnClickListener for searchTextview - Add intent to navigate from the mapView to searchView
…search into arieum_step2
mkSpace
requested changes
Jul 12, 2024
Comment on lines
+46
to
+48
| placeRepository = PlaceRepository(this) | ||
| placeRepository.reset() | ||
| placeList = placeRepository.insertInitialData() |
There was a problem hiding this comment.
아직 Repository들을 View에서 직접 세팅하고 사용하고 계신데 ViewModel로 옮기셔야 합니다
| } | ||
| recyclerView.adapter = resultAdapter | ||
| recyclerView.layoutManager = LinearLayoutManager(this) | ||
| resultAdapter.submitList(placeList) |
There was a problem hiding this comment.
ViewModel을 적용하기가 조금 어렵다고 하셨는데 이번주까지만 MVC로 진행하시고 이번에 Step3 작업 하신 이후에는 조금씩이나마 ViewModel을 사용해서 데이터 흐름이 LocalDB -> View로 오는 흐름을 만들어보세요
실무에서는 다 이런 방식으로 설계하기 때문에 결국 부딪혀야 합니다. 강사님과 멘토 믿고 부족해도 괜찮으니 시도해보세요!
…ibutes with 'start'end'
…ecessary textWatcher variable and directly adding the TextWatcher to the input EditText
…for clear mapping of JSON response_fields
mkSpace
approved these changes
Jul 14, 2024
|
아림님 키워드 검색 부분이 구현되지 않은것 같은데 맞나요?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
아직 STEP0, STEP1 피드백을 못받았지만...! 슬쩍 STEP2 PR도 보내봅니다