전남대_Android 신혜서 3주차 과제 STEP1 #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
검색결과가 없다는 문구 visibility로 정리
검색결과가 없다는 문구 visibility로 정리
에뮬 실행 안되는 오류 수정
SearchView로 변경했습니다.
+ NullPointerException 에러해결
+ NullPointerException 에러해결
RestAPI키를 잘못입력함
RestAPI키를 잘못입력함
bigstark
requested changes
Jul 14, 2024
Comment on lines
+6
to
+9
| @SerializedName("category_group_name") val categoryName: String, | ||
| @SerializedName("id") val id: String, | ||
| @SerializedName("address_name") val addressName: String, | ||
| @SerializedName("place_name") val placeName: String? |
There was a problem hiding this comment.
Gson 을 사용한다면 null safety 하지 않을 수 있어요. 모두 null 처리해주시면 조금 더 안전하게 사용할 수 있어요.
Comment on lines
+4
to
+6
| val place_name: String, | ||
| val address_name: String, | ||
| val category_group_name: String |
Comment on lines
+5
to
+26
| class SearchViewModel private constructor(private val searchRepository: SearchRepo) : ViewModel() { | ||
| companion object { | ||
| @Volatile private var instance: SearchViewModel? = null | ||
|
|
||
| fun getInstance(searchRepository: SearchRepo): SearchViewModel { | ||
| return instance ?: synchronized(this) { | ||
| instance ?: SearchViewModel(searchRepository).also { instance = it } | ||
| } | ||
| } | ||
| } | ||
| fun insertSearchData(data: String) { | ||
| searchRepository.insertSearchData(data) | ||
| } | ||
|
|
||
| fun getAllSearchData(): List<String> { | ||
| return searchRepository.getAllSearchData() | ||
| } | ||
|
|
||
| fun bind(s: String) { | ||
|
|
||
| } | ||
| } |
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| KakaoSdk.init(this, "e6a7c826ae7a55df129b8be2c636e213") |
There was a problem hiding this comment.
이러한 api key 들은 코드에 노출되면 안됩니다. 요 블로그 한번 읽어보시면 도움이 될 듯 합니다.
| private lateinit var searchResultAdapter: PlaceAdapter | ||
| private lateinit var savedSearchAdapter: SavedSearchAdapter | ||
| private lateinit var databaseHelper: MyDatabaseHelper | ||
| private lateinit var MapViewKakao: MapView |
Comment on lines
+57
to
+79
| private fun createKakaoApiService(): KakaoApiService { | ||
| val logging = HttpLoggingInterceptor().apply { | ||
| level = HttpLoggingInterceptor.Level.BASIC | ||
| } | ||
|
|
||
| val okHttpClient = OkHttpClient.Builder() | ||
| .addInterceptor(logging) | ||
| .addInterceptor { chain -> | ||
| val request = chain.request().newBuilder() | ||
| .addHeader("Authorization", "KakaoAK 13c6b4e1c003d0f42b3b07888391c355") | ||
| .build() | ||
| chain.proceed(request) | ||
| } | ||
| .build() | ||
|
|
||
| val retrofit = Retrofit.Builder() | ||
| .baseUrl("https://dapi.kakao.com") | ||
| .client(okHttpClient) | ||
| .addConverterFactory(GsonConverterFactory.create()) | ||
| .build() | ||
|
|
||
| return retrofit.create(KakaoApiService::class.java) | ||
| } |
There was a problem hiding this comment.
KakaoApiService 는 Activity 에서 생성하면 안될 것 같습니다. kakao api service 를 사용하는 부분은 최대한 viewModel 로 로직을 옮겨주시면 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기능 요구 사항
프로그래밍 요구 사항
How to make
(Response 파일에 생성해도 좋았을텐데 약간 돌고돌아오는(?) 느낌입니다!! 쓸데없이 파일을 많이 생성한 느낌)
코드를 보면서 조금 아쉬웠던(?) 점 입니다.
MapContract.COLUMN_ADDRESS to (document.addressName ?: "No Address"),
MapContract.COLUMN_CATEGORY to (document.categoryName ?: "No Category")
이 함수의 경우 그냥 MapContract를 삭제하고 document.categoryName ?: "No Category" 라고 해도 괜찮았을 것 같습니당...STEP2에 고쳐볼께용