Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ICU charset conversion implementation #64

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Added ICU charset conversion implementation #64

wants to merge 2 commits into from

Conversation

GreyCat
Copy link
Member

@GreyCat GreyCat commented Jul 27, 2023 •
edited
Loading

This adds another option to use ICU library for character set conversions in C++ runtime.

Known caveats so far:

  • By default, ICU substitute illegal sequences with placeholder codepoints rather than actively raising an alarm (which we can surface as exception), so all illegal sequence tests fail for now.
  • There's debug print to cout that has to be yet cleaned up.

generalmimon added a commit that referenced this pull request Nov 3, 2023
@generalmimon
GH Actions: run apt-get update before installing packages
e5e45db 
See #64 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generalmimon generalmimon generalmimon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GreyCat @generalmimon