Fix large heap allocation during load broken files. #46
Conversation
kaitai/kaitaistream.cpp
Outdated
| else if (len > size()) | ||
| { |
There was a problem hiding this comment.
Probably it should be else if (....) {.
| } else if (len == 0) { | ||
| return std::string(); | ||
| } else if (len > size()) { | ||
| throw std::runtime_error("read_bytes: requested length greater than stream size"); | ||
| } |
There was a problem hiding this comment.
In general, that's a bad idea to call size() if we can avoid that. First of all, not all streams are finite and have sizes at all. The way that size() is implemented in KS runtime is by seeking to end of stream, getting position index there, and going back to pre-memorized original location. It won't work on infinite streams like ones coming from IO port or networking socket.
Moreover, reading past end-of-stream throws a well-defined exception like std::ifstream::failure, is (1) arguably better than throwing a std::runtime_error with some text, (2) relied upon in existing codebases.
There was a problem hiding this comment.
As I understand kaitaia::ostream can not work with infinite/non seekable streams. See the realization of kaitai::kstream::read_bytes_term(...), kaitai::kstream::size(...), kaitai::kstream::seek(...).
No description provided.