GIFImageView: add missing call to super #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I didn't have the chance to try things out in Xcode 12 but I will take a look and merge your PR after that! |
|
I saw some crashes from unrecognized selectors on this super call - added a commit to deal with that - but maybe this needs more investigation... |
|
BTW - this issue is affecting lots of image libraries in the Xcode 12 betas: Updated to the latest solution suggested in that YYWebImage gissue |
|
Thanks for looking into this @jverdi! |
Closed
|
I will merge this for now. If a future Beta fixes it we can revert. |
|
@jverdi thank you for the solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building my app in Xcode 12 beta 1, I noticed that none of my images were appearing.
I found that this call to super in
display(_ layer: CALayer)is important in iOS 14 - and suspect it is probably safe/good to have in previous versions too.