Improve GetImage platform handling #557
Merged
+106
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
local daemon is not able to pull multiple arch images nor you can ask it to give you an image and a platform. So if the local daemon has image X for platform amd64 and you wanted it for arm64 it would return that wrong platform image. This commit checks if the platform is the proper one and if not falls back into asking the remote for the proper platform image Signed-off-by: Itxaka <itxaka@kairos.io>
jimmykarily
approved these changes
Jan 16, 2025
Signed-off-by: Itxaka <itxaka@kairos.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
=======================================
Coverage 52.55% 52.55%
=======================================
Files 19 19
Lines 1998 1998
=======================================
Hits 1050 1050
Misses 818 818
Partials 130 130 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local daemon is not able to pull multiple arch images nor you can ask it to give you an image and a platform. So if the local daemon has image X for platform amd64 and you wanted it for arm64 it would return that wrong platform image.
This commit checks if the platform is the proper one and if not falls back into asking the remote for the proper platform image