Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interface: Add CallMsg.GasFeeCap,GasTipCap #29

Merged
merged 2 commits into from
Jun 28, 2024
Merged

interface: Add CallMsg.GasFeeCap,GasTipCap #29

merged 2 commits into from
Jun 28, 2024

Conversation

blukat29
Copy link
Contributor

Proposed changes

  • Add KIP-162 support to the Go client for the RPC (kaia_client and sc/remote_backend).

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the [ ] I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@blukat29 blukat29 force-pushed the callmsg-tip-fields branch from c3295e3 to 0f36e9e Compare June 27, 2024 13:45
@blukat29 blukat29 force-pushed the callmsg-tip-fields branch from 0f36e9e to f426d07 Compare June 27, 2024 13:49
@blukat29 blukat29 marked this pull request as ready for review June 27, 2024 14:08
@blukat29 blukat29 requested review from ian0371 and hyeonLewis June 27, 2024 14:08
yoomee1313
yoomee1313 reviewed Jun 28, 2024
View reviewed changes
interfaces.go Outdated Show resolved Hide resolved
@blukat29 blukat29 merged commit e26ddc7 into kaiachain:dev Jun 28, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hyeonLewis hyeonLewis hyeonLewis approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@aidan-kwon aidan-kwon aidan-kwon approved these changes

@2dvorak 2dvorak 2dvorak approved these changes

@ian0371 ian0371 ian0371 approved these changes

@hyunsooda hyunsooda Awaiting requested review from hyunsooda

@kjeom kjeom Awaiting requested review from kjeom

@JayChoi1736 JayChoi1736 Awaiting requested review from JayChoi1736

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blukat29 @ian0371 @2dvorak @aidan-kwon @yoomee1313 @hyeonLewis