Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kaiax/gov: Rename getters #184

Merged
merged 12 commits into from
Dec 26, 2024
Merged

Conversation

ian0371
Copy link
Collaborator

@ian0371 ian0371 commented Dec 23, 2024

Proposed changes

Rename getters

  • EffectiveParamSet -> GetParamSet
  • EffectiveParamsPartial -> GetPartialParamSet

Others

  • bugfix: lowestVoteScannedBlockNumKey sometimes stored block num or epoch idx. It's been renamed to lowestVoteScannedEpochIdxKey and now stores epoch idx only.
  • schema.go won't use lock for a single DB lookup.
  • Unit tests has been added.
  • Migration goroutine stops gracefully.
  • The redundant first parameter from AddVote() has been removed.

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Follow up of #177.

@ian0371 ian0371 requested a review from hyeonLewis December 23, 2024 11:12
@ian0371 ian0371 self-assigned this Dec 23, 2024
@ian0371 ian0371 marked this pull request as draft December 23, 2024 11:13
@ian0371 ian0371 force-pushed the kaiax/rename-gov-getter branch from 22cba35 to 0f9f0b0 Compare December 26, 2024 04:30
@ian0371 ian0371 force-pushed the kaiax/rename-gov-getter branch from 0f9f0b0 to 21fb147 Compare December 26, 2024 04:58
@ian0371 ian0371 marked this pull request as ready for review December 26, 2024 06:14
@ian0371 ian0371 merged commit 437b2bb into kaiachain:dev Dec 26, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants