-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kaiax/gov: Rename getters #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian0371
force-pushed
the
kaiax/rename-gov-getter
branch
from
December 26, 2024 04:30
22cba35
to
0f9f0b0
Compare
ian0371
force-pushed
the
kaiax/rename-gov-getter
branch
from
December 26, 2024 04:58
0f9f0b0
to
21fb147
Compare
yoomee1313
reviewed
Dec 26, 2024
yoomee1313
approved these changes
Dec 26, 2024
blukat29
approved these changes
Dec 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Rename getters
Others
lowestVoteScannedBlockNumKey
sometimes stored block num or epoch idx. It's been renamed tolowestVoteScannedEpochIdxKey
and now stores epoch idx only.schema.go
won't use lock for a single DB lookup.AddVote()
has been removed.Types of changes
Checklist
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Follow up of #177.