Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all exit exceptions when coordinator call member #615

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Catch all exit exceptions when coordinator call member #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21c4f1a
fix: handle all exit exceptions when coordinator calls member process
zmstone Dec 14, 2024
2b018ea
docs: add changelogs since 4.3.2
zmstone Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
# Changelog

- 4.3.3
- Catch `exit` exception when group coordinator calls group member (owner) process.
- Add `unknown_topic_cache_ttl` option in client config.
- Doc improvements.

- 4.3.2
- Upgrade kafka_protocol from 4.1.9 to 4.1.10 for partition leader discover/connect timeout fix.
- Upgrade kafka_protocol from 4.1.9 to 4.1.10 for partition leader discover/connect timeout fix.

- 4.3.1
- Fixed `brod_client:stop_consumer` so that it doesn't crash the client process if an unknown consumer is given as argument.
Expand Down
6 changes: 4 additions & 2 deletions src/brod_group_coordinator.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,10 @@
try
EXPR
catch
exit:{noproc, {gen_server, call, [MemberPid | _]}} ->
exit({shutdown, member_down})
exit:{noproc, _} ->
exit({shutdown, member_down});
exit:{Reason, _} ->
exit({shutdown, {member_down, Reason}})
end).

-type config() :: brod:group_config().
Expand Down