Hyperlane natives fixes #1362
Merged
Hyperlane natives fixes #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
force-pushed
the
ak3n/hyperlane-native-add-chainid
branch
2 times, most recently
from
6d63502 to
f66ec93
Compare
ghost
force-pushed
the
ak3n/hyperlane-native-add-chainid
branch
5 times, most recently
from
583d721 to
20bc897
Compare
ghost
marked this pull request as ready for review
ghost
force-pushed
the
ak3n/hyperlane-native-add-chainid
branch
2 times, most recently
from
aad50db to
f1d39bf
Compare
chessai
force-pushed
the
ak3n/hyperlane-native-add-chainid
branch
2 times, most recently
from
bd493fb to
d5789b5
Compare
jmcardon
approved these changes
Jun 13, 2024
chessai
force-pushed
the
ak3n/hyperlane-native-add-chainid
branch
from
d5789b5 to
468d64c
Compare
edmundnoble
approved these changes
Jun 13, 2024
emilypi
approved these changes
Jun 13, 2024
|
|
||
| return decoded | ||
|
|
||
| parseChainId :: forall a. (a ~ Word16) => Text -> Either HyperlaneError a |
There was a problem hiding this comment.
if this has to be a Word16, why is this an equality constraint?
There was a problem hiding this comment.
refactoring purposes with show, i just wanted to write a everywhere. but you're right it's probably not worth it.
Signed-off-by: Evgenii Akentev <[email protected]> Change-Id: I8f09e97090ae3fbe32bbe0339414ef175d987800
chessai
force-pushed
the
ak3n/hyperlane-native-add-chainid
branch
from
468d64c to
02e1f61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding chainweb PR: kadena-io/chainweb-node#1901
PR checklist:
pact -t), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: