fix: support 3.x to 4.x upgrades when num_tokens are not set in k8ssandraCluster #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karol Szwaj <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
+ Coverage 57.34% 57.38% +0.03%
==========================================
Files 100 100
Lines 10193 10233 +40
==========================================
+ Hits 5845 5872 +27
- Misses 3836 3845 +9
- Partials 512 516 +4
|
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
cnvergence
changed the title
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
cnvergence
force-pushed
the
fix-validating-upgrade
branch
from
1e6b17f to
016f1f5
Compare
Signed-off-by: Karol Szwaj <[email protected]>
cnvergence
force-pushed
the
fix-validating-upgrade
branch
from
016f1f5 to
be53ad3
Compare
Signed-off-by: Karol Szwaj <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
cnvergence
changed the title
burmanm
approved these changes
Dec 20, 2023
|
The upgrade from 3.11.14 -> 4.1.3 does not work as intended if the num_tokens is not manually set (it will fail to "trying to change num_tokens"), so it didn't correctly fetch the existing ones in that sense. But I'll create a follow-up ticket to fix that. |
|
Thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #1119
Checklist