Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.27] Added support for env *_PROXY variables for agent loadbalancer #9117

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

dereknola
Copy link
Member

Backport #9070 to release-1.27

Linked Issues

#9114

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner January 2, 2024 20:15
@dereknola dereknola force-pushed the issue-8976_release-1.27 branch from 39c47d9 to ed9538d Compare January 2, 2024 20:17
Signed-off-by: Yodo <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola force-pushed the issue-8976_release-1.27 branch from ed9538d to a37aaed Compare January 7, 2024 03:01
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (2c249a3) 50.19% compared to head (a37aaed) 46.67%.

Files Patch % Lines
pkg/agent/loadbalancer/servers.go 32.35% 23 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #9117      +/-   ##
================================================
- Coverage         50.19%   46.67%   -3.52%     
================================================
  Files               148      148              
  Lines             15768    15798      +30     
================================================
- Hits               7914     7373     -541     
- Misses             6613     7223     +610     
+ Partials           1241     1202      -39     
Flag Coverage Δ
e2etests ?
inttests 44.22% <32.35%> (-0.20%) ⬇️
unittests 18.41% <32.35%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 5ecf175 into k3s-io:release-1.27 Jan 7, 2024
15 checks passed
@dereknola dereknola deleted the issue-8976_release-1.27 branch January 9, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants