-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load nft modules at startup #11524
Load nft modules at startup #11524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add checks for these in https://github.com/k3s-io/k3s/blob/master/contrib/util/check-config.sh
Probably. I'm also curious if this is a complete list of all the modules we'd need, it seems short compared to the legacy iptables module list. |
Well, these are the one related to the nat chain, as well as filter chain, it seems all what svclb needs |
Signed-off-by: galal-hussein <[email protected]>
ad0ce81
to
d44c05e
Compare
Can you try on an ipv6 host and see if there are any more needed to support that as well? |
sure |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11524 +/- ##
==========================================
- Coverage 43.85% 36.82% -7.04%
==========================================
Files 181 164 -17
Lines 18809 18333 -476
==========================================
- Hits 8249 6751 -1498
- Misses 9351 10493 +1142
+ Partials 1209 1089 -120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
Issue: #11525
User-Facing Change
Further Comments