Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load nft modules at startup #11524

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

galal-hussein
Copy link
Contributor

@galal-hussein galal-hussein commented Jan 6, 2025

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

Issue: #11525

User-Facing Change


Further Comments

@galal-hussein galal-hussein requested a review from a team as a code owner January 6, 2025 20:17
install.sh Outdated Show resolved Hide resolved
Copy link
Member

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandond
Copy link
Member

brandond commented Jan 6, 2025

Probably. I'm also curious if this is a complete list of all the modules we'd need, it seems short compared to the legacy iptables module list.

@galal-hussein
Copy link
Contributor Author

Probably. I'm also curious if this is a complete list of all the modules we'd need, it seems short compared to the legacy iptables module list.

Well, these are the one related to the nat chain, as well as filter chain, it seems all what svclb needs

@brandond
Copy link
Member

brandond commented Jan 6, 2025

Can you try on an ipv6 host and see if there are any more needed to support that as well?

@galal-hussein
Copy link
Contributor Author

Can you try on an ipv6 host and see if there are any more needed to support that as well?

sure

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.82%. Comparing base (e64e2fc) to head (d44c05e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e64e2fc) and HEAD (d44c05e). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (e64e2fc) HEAD (d44c05e)
unittests 1 0
inttests 11 8
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11524      +/-   ##
==========================================
- Coverage   43.85%   36.82%   -7.04%     
==========================================
  Files         181      164      -17     
  Lines       18809    18333     -476     
==========================================
- Hits         8249     6751    -1498     
- Misses       9351    10493    +1142     
+ Partials     1209     1089     -120     
Flag Coverage Δ
e2etests 35.90% <100.00%> (+0.10%) ⬆️
inttests 31.02% <100.00%> (-3.96%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galal-hussein galal-hussein merged commit e6f6fce into k3s-io:master Jan 7, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants