Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.28] Fixes "file exists" error from CNI bins when upgrading k3s #11128

Merged

Conversation

brandond
Copy link
Member

Proposed Changes

Unlink existing CNI bin symlinks to avoid "file exists" error when upgrading K3s from an existing version with stable CNI bin support.

Also added support for enabling debug logging early in startup of the self-extracting wrapper; this was not being done early enough to capture debug level logs from the extract function.

Types of Changes

bugfix

Verification

  • see linked issue comment

Testing

Linked Issues

User-Facing Change

Further Comments

Fixes "file exists" error when upgrading k3s.

Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner October 19, 2024 04:39
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.29%. Comparing base (63bfb19) to head (d1f7cc5).
Report is 1 commits behind head on release-1.28.

❗ There is a different number of reports uploaded between BASE (63bfb19) and HEAD (d1f7cc5). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (63bfb19) HEAD (d1f7cc5)
unittests 1 0
e2etests 7 6
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28   #11128      +/-   ##
================================================
- Coverage         40.52%   33.29%   -7.23%     
================================================
  Files               179      162      -17     
  Lines             18596    17848     -748     
================================================
- Hits               7536     5943    -1593     
- Misses             9777    10908    +1131     
+ Partials           1283      997     -286     
Flag Coverage Δ
e2etests 33.29% <ø> (-12.17%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 0892b96 into k3s-io:release-1.28 Oct 21, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants