fix(loadt): Fix a bug that overwrote the original error #1143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did in this PR
Currently at
runn loadt
cmd, the existing error (err
) was overwritten by the new error returned fromrunn.RemoveCacheDir()
. This change useserrors.Join(err, ...)
to merge both errors and ensure the original context is not lost.Background
By this bug, even if the condition of
--threshold
flag does not meets, no error was returned (exit with 0).before
after