Merge pull request #50 from k1LoW/fix-create_table

Fix --create-bq-table

cmd/create_table.go

@@ -11,8 +11,8 @@ import (
 )
 
 func createBQTable(ctx context.Context, c *config.Config) error {
-	if !c.DatastoreConfigReady() {
-		return errors.New("datastore config not ready")
+	if !c.ReportConfigDatastoresReady() {
+		return errors.New("report.datastores is not set")
 	}
 	if err := c.BuildReportConfig(); err != nil {
 		return err

config/report.go

@@ -15,6 +15,10 @@ func (c *Config) ReportConfigReady() bool {
 	if c.Report == nil {
 		return false
 	}
+	if !c.ReportConfigDatastoresReady() {
+		_, _ = fmt.Fprintf(os.Stderr, "Skip storing the report: report.datastores is not set %v\n", c.Report.Datastores)
+		return false
+	}
 	ok, err := CheckIf(c.Report.If)
 	if err != nil {
 		_, _ = fmt.Fprintf(os.Stderr, "Skip storing the report: %v\n", err)
@@ -27,6 +31,13 @@ func (c *Config) ReportConfigReady() bool {
 	return true
 }
 
+func (c *Config) ReportConfigDatastoresReady() bool {
+	if c.Report == nil {
+		return false
+	}
+	return len(c.Report.Datastores) > 0
+}
+
 func (c *Config) BuildReportConfig() error {
 	if len(c.Report.Datastores) == 0 {
 		return errors.New("report.datastores is not set")

config/report_test.go

@@ -0,0 +1,33 @@
+package config
+
+import (
+	"testing"
+)
+
+func TestReportConfigReady(t *testing.T) {
+	tests := []struct {
+		c    *Config
+		want bool
+	}{
+		{
+			New(),
+			false,
+		},
+		{
+			&Config{
+				Report: &ConfigReport{
+					Datastores: []string{
+						"s3://octocov-test/reports",
+					},
+				},
+			},
+			true,
+		},
+	}
+	for _, tt := range tests {
+		got := tt.c.ReportConfigReady()
+		if got != tt.want {
+			t.Errorf("got %v\nwant %v", got, tt.want)
+		}
+	}
+}