Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-velocity and add go-pos and go-pos-unsafe test #17

Closed
wants to merge 18 commits into from

Conversation

knorth55
Copy link

@knorth55 knorth55 commented Nov 4, 2019

I update :go-velocity test to work properly.
I also add test-go-pos and test-go-pos-unsafe.

this PR includes jsk-ros-pkg#411 and jsk-ros-pkg#412
test-go-pos-unsafe is for jsk-ros-pkg#406.

pr2eus/pr2-interface.l Outdated Show resolved Hide resolved
@knorth55 knorth55 changed the title Update go-velocity test Update go-velocity Nov 5, 2019
@knorth55 knorth55 changed the title Update go-velocity Update go-velocity test Nov 5, 2019
@knorth55 knorth55 changed the title Update go-velocity test Update go-velocity and add go-pos and go-pos-unsafe test Nov 6, 2019
@knorth55
Copy link
Author

knorth55 commented Nov 6, 2019

I add test for :go-pos and :go-pos-unsafe
:go-pos-unsafe is override in test file, and I could not write it elegantly.

@knorth55
Copy link
Author

knorth55 commented Nov 14, 2019

Build failure results:
Indigo:

Traceback (most recent call last):

  File "/opt/ros/indigo/share/rostest/cmake/../../../bin/rostest", line 36, in <module>

    rostestmain()

  File "/opt/ros/indigo/lib/python2.7/dist-packages/rostest/__init__.py", line 274, in rostestmain

    _main()

  File "/opt/ros/indigo/lib/python2.7/dist-packages/rostest/rostest_main.py", line 159, in rostestmain

    testCase = rostest.runner.createUnitTest(pkg, test_file, options.reuse_master, options.clear, options.results_base_dir)

  File "/opt/ros/indigo/lib/python2.7/dist-packages/rostest/runner.py", line 229, in createUnitTest

    config = roslaunch.parent.load_config_default([test_file], None)

  File "/opt/ros/indigo/lib/python2.7/dist-packages/roslaunch/config.py", line 455, in load_config_default

    raise RLException(e)

roslaunch.core.RLException: unused args [KINECT1, KINECT2] for include of [/opt/ros/indigo/share/pr2_gazebo/launch/pr2.launch]

PR2/pr2_simulator@cda2e39#diff-41e5fda4ba4f344641c06c6292fa2450
This commits is in 2.0.8 and last release of indigo is 2.0.7.

Kinetic: Timeout
Melodic:

/usr/bin/make -f CMakeFiles/_run_tests_pr2eus_rostest_test_pr2-ri-test.launch.dir/build.make CMakeFiles/_run_tests_pr2eus_rostest_test_pr2-ri-test.launch.dir/depend

xacro: in-order processing became default in ROS Melodic. You can drop the option.

Traceback (most recent call last):

  File "/opt/ros/melodic/share/rostest/cmake/../../../bin/rostest", line 36, in <module>

    rostestmain()

  File "/opt/ros/melodic/lib/python2.7/dist-packages/rostest/__init__.py", line 274, in rostestmain

    _main()

  File "/opt/ros/melodic/lib/python2.7/dist-packages/rostest/rostest_main.py", line 159, in rostestmain

    testCase = rostest.runner.createUnitTest(pkg, test_file, options.reuse_master, options.clear, options.results_base_dir)

  File "/opt/ros/melodic/lib/python2.7/dist-packages/rostest/runner.py", line 229, in createUnitTest

    config = roslaunch.parent.load_config_default([test_file], None)

  File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/config.py", line 457, in load_config_default

    loader.load(f, config, argv=args, verbose=verbose)

  File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/xmlloader.py", line 751, in load

    self._load_launch(launch, ros_config, is_core=core, filename=filename, argv=argv, verbose=verbose)

  File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/xmlloader.py", line 723, in _load_launch

    self._recurse_load(ros_config, launch.childNodes, self.root_context, None, is_core, verbose)

  File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/xmlloader.py", line 687, in _recurse_load

    val = self._include_tag(tag, context, ros_config, default_machine, is_core, verbose)

  File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/xmlloader.py", line 95, in call

    return f(*args, **kwds)

  File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/xmlloader.py", line 591, in _include_tag

    inc_filename = self.resolve_args(tag.attributes['file'].value, context)

  File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/xmlloader.py", line 185, in resolve_args

    return substitution_args.resolve_args(args, context=context.resolve_dict, resolve_anon=self.resolve_anon)

  File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/substitution_args.py", line 392, in resolve_args

    resolved = _resolve_args(resolved, context, resolve_anon, commands)

  File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/substitution_args.py", line 405, in _resolve_args

    resolved = commands[command](resolved, a, args, context)

  File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/substitution_args.py", line 166, in _find

    source_path_to_packages=source_path_to_packages)

  File "/opt/ros/melodic/lib/python2.7/dist-packages/roslaunch/substitution_args.py", line 212, in _find_executable

    full_path = _get_executable_path(rp.get_path(args[0]), path)

  File "/usr/lib/python2.7/dist-packages/rospkg/rospack.py", line 203, in get_path

    raise ResourceNotFound(name, ros_paths=self._ros_paths)

rospkg.common.ResourceNotFound: pr2_navigation_slam

ROS path [0]=/opt/ros/melodic/share/ros

ROS path [1]=/home/travis/ros/ws_jsk_pr2eus/src/jsk_pr2eus/pr2eus

ROS path [2]=/home/travis/ros/ws_jsk_pr2eus/src/jsk_pr2eus/pr2eus

ROS path [3]=/home/travis/ros/ws_jsk_pr2eus/src/jsk_pr2eus/pr2eus_moveit

ROS path [4]=/home/travis/ros/ws_jsk_pr2eus/src/jsk_pr2eus/pr2eus_tutorials

ROS path [5]=/opt/ros/melodic/share

Cannot find results, writing failure results to '/home/travis/ros/ws_jsk_pr2eus/build/pr2eus/test_results/pr2eus/MISSING-rostest-test_pr2-ri-test.xml'

@knorth55
Copy link
Author

I fixed the indigo problem by setting env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants