Skip to content

Commit

Permalink
Rename SKIP_CODEGEN_TESTS into ENABLE_GCC_CODEGEN
Browse files Browse the repository at this point in the history
  • Loading branch information
GuillaumeGomez committed Nov 2, 2023
1 parent 25a96ca commit a141b69
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
env: {}
- name: x86_64-gnu-llvm-15
env:
SKIP_CODEGEN_TESTS: "1"
ENABLE_GCC_CODEGEN: "1"
os: ubuntu-20.04-16core-64gb
- name: x86_64-gnu-tools
os: ubuntu-20.04-16core-64gb
Expand Down
4 changes: 2 additions & 2 deletions src/ci/docker/host-x86_64/x86_64-gnu-llvm-15/script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -ex

# Only run the stage 1 tests on merges, not on PR CI jobs.
if [[ -z "${PR_CI_JOB}" ]]; then
if [[ "${SKIP_CODEGEN_TESTS}" == "1" ]]; then
if [[ "${ENABLE_GCC_CODEGEN}" == "1" ]]; then
../x.py --stage 1 test --skip src/tools/tidy --skip tests/codegen
else
../x.py --stage 1 test --skip src/tools/tidy
Expand All @@ -24,7 +24,7 @@ if [[ -z "${PR_CI_JOB}" ]]; then
fi

# NOTE: intentionally uses all of `x.py`, `x`, and `x.ps1` to make sure they all work on Linux.
if [[ "${SKIP_CODEGEN_TESTS}" == "1" ]]; then
if [[ "${ENABLE_GCC_CODEGEN}" == "1" ]]; then
../x.py --stage 2 test --skip src/tools/tidy --skip tests/codegen
else
../x.py --stage 2 test --skip src/tools/tidy
Expand Down
2 changes: 1 addition & 1 deletion src/ci/docker/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ docker \
run \
--workdir /checkout/obj \
--env SRC=/checkout \
--env "SKIP_CODEGEN_TESTS=$SKIP_CODEGEN_TESTS" \
--env "ENABLE_GCC_CODEGEN=$ENABLE_GCC_CODEGEN" \
$args \
--env CARGO_HOME=/cargo \
--env DEPLOY \
Expand Down
2 changes: 1 addition & 1 deletion src/ci/github-actions/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ jobs:
- name: x86_64-gnu-llvm-15
<<: *job-linux-16c
env:
SKIP_CODEGEN_TESTS: "1"
ENABLE_GCC_CODEGEN: "1"

- name: x86_64-gnu-tools
<<: *job-linux-16c
Expand Down
2 changes: 1 addition & 1 deletion src/ci/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ else

RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.verify-llvm-ir"

if [[ "${SKIP_CODEGEN_TESTS}" == "1" ]]; then
if [[ "${ENABLE_GCC_CODEGEN}" == "1" ]]; then
# Test the Cranelift backend in CI. Bootstrap knows which targets to run tests on.
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-backends=llvm,cranelift"
else
Expand Down

0 comments on commit a141b69

Please sign in to comment.