Migrate JSON.parse() to parseJson() calls #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jpabeem, Thanks for your PR (and also for the missing pull_request event for the automated test workflow 🤦♂️). Such as : import path from 'path';
const filename = path.basename("/foo/bar/fr.json");
parseJson('{\n\t"foo": true,\n}', filename); |
jy95
reviewed
Nov 3, 2021
| @@ -60,7 +61,7 @@ async function verify_files_entry([_, i18nPath]: [string, any]): Promise< | |||
| } | |||
| // check if the file is a JSON | |||
| try { | |||
| JSON.parse(potentialJSON.toString()); | |||
| parseJson(potentialJSON.toString()); | |||
| return Promise.resolve(true); | |||
| } catch (error) { | |||
| return Promise.reject(new Error(`${i18nPath} isn't a valid JSON`)); | |||
There was a problem hiding this comment.
Promise.reject(error) instead as parseJson raises a JSONError if an issue arose
| @@ -18,7 +20,7 @@ export default class CommandBuilder { | |||
| let ext = extname(configPath); | |||
| return /\.js$/i.test(ext) | |||
| ? require(configPath) | |||
| : JSON.parse(readFileSync(configPath, 'utf-8')); | |||
| : parseJson(readFileSync(configPath, 'utf-8')); | |||
There was a problem hiding this comment.
Suggested improvement :
const filename = path.basename(configPath);
parseJson(readFileSync(configPath, 'utf-8'), filename);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #35
@jy95 can you check this PR?